Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ShallowCopy for IteratorOfPartitionsSet #4505

Merged
merged 1 commit into from
May 25, 2021
Merged

Fix ShallowCopy for IteratorOfPartitionsSet #4505

merged 1 commit into from
May 25, 2021

Conversation

fingolfin
Copy link
Member

Found this while reviewing PR #4502.

@fingolfin fingolfin added kind: bug Issues describing general bugs, and PRs fixing them kind: bug: unexpected error Issues describing bugs in which computation unexpectedly encounters an error, and PRs fixing them release notes: use title For PRs: the title of this PR is suitable for direct use in the release notes labels May 20, 2021
@fingolfin fingolfin mentioned this pull request May 20, 2021
Merged
8 tasks
@wilfwilson wilfwilson changed the title Fix ShallowCopy for IteratorOfPartitionsSet Fix ShallowCopy for IteratorOfPartitionsSet May 25, 2021
@fingolfin fingolfin merged commit 5a1fe5f into gap-system:master May 25, 2021
@fingolfin fingolfin deleted the mh/combinat branch May 25, 2021 10:13
@olexandr-konovalov
Copy link
Member

olexandr-konovalov commented May 26, 2021 •
edited
Loading

@fingolfin

This worked yesterday and does not work today - perhaps related? Happens when all packages are loaded:

########> Diff in /circa/scratch/gap-jenkins/workspace/GAP-pkg-update-master-q\
uicktest/GAPCOPTS/64build/GAPGMP/gmp/GAPTARGET/standard/label/kovacs/GAP-pkg-u\
pdate-master-snapshot/tst/testinstall/combinat.tst:474
# Input is:
for s in [[], [5], [1,2,3,4], [2,5,7], ["a","b","c","d","e"], [3..13]] do
     pn1:= PartitionsSet( s );
     pn2:= List( IteratorOfPartitionsSet( s ) );
     if Length(pn1) <> Length(pn2) then
       Error( "wrong number of elements" );
     elif Set(pn1) <> Set(pn2) then
       Error( "different elements" );
     fi;
   od;
# Expected output:
# But found:
Error, reached the pre-set memory limit
(change it with the -o command line option)
########

but only in the GAP master branch - works fine in stable-4.11.

@olexandr-konovalov olexandr-konovalov mentioned this pull request May 27, 2021
Closed
@fingolfin fingolfin added regression A bug that only occurs in the branch, not in a release release notes: not needed PRs introducing changes that are wholly irrelevant to the release notes and removed release notes: use title For PRs: the title of this PR is suitable for direct use in the release notes labels Aug 18, 2022
@fingolfin
Copy link
Member Author

Doesn't have to be in the release notes as this function is new in GAP 4.12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wilfwilson wilfwilson wilfwilson approved these changes

Assignees
No one assigned
Labels
kind: bug: unexpected error Issues describing bugs in which computation unexpectedly encounters an error, and PRs fixing them kind: bug Issues describing general bugs, and PRs fixing them regression A bug that only occurs in the branch, not in a release release notes: not needed PRs introducing changes that are wholly irrelevant to the release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fingolfin @olexandr-konovalov @wilfwilson